UI: Update manager to respect parameters.docsOnly in stories.json
#18433
Conversation
We sometimes set this in 6.x (if using `storyStoreV7 = false` and `breakingChangesV7 = false`), but we plan to use this for back-compat purposes in 7.x.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c8f611c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
tmeasday
added
patch:yes
|
We'd like to double-patch this back to 6.4.x |
Codecov Report
@@ Coverage Diff @@
## next #18433 +/- ##
=======================================
Coverage 32.01% 32.01%
=======================================
Files 975 975
Lines 19234 19234
Branches 4033 4033
=======================================
Hits 6158 6158
Misses 12513 12513
Partials 563 563
Continue to review full report at Codecov.
|
shilman
changed the title
parameters.docsOnly in stories.json.parameters.docsOnly in stories.json
| id, | ||
| kind: title, | ||
| name, | ||
| parameters: { fileName: importPath, options: {}, docsOnly, ...parameters }, |
There was a problem hiding this comment.
@tmeasday could ...parameters ever override options or fileName? if so, would that be an issue?
There was a problem hiding this comment.
I think fileName will always be the same. I think we just define options here because other code assumes it exists, I don't really remember why.
shilman
added
story index
patch:done
…fields-in-storiesjson-and UI: Update manager to respect `parameters.docsOnly` in `stories.json`
shilman
added
maintenance
We sometimes set this in 6.x (if using
storyStoreV7 = falseandbreakingChangesV7 = false), but we plan to use this for back-compat purposes in 7.x.How to test
See tests